On Sun, Feb 24, 2019 at 06:26:46AM -0500, Zhu Yanjun wrote: > In the function rxe_init_packet, based on av->network_type, > skb->protocol is set to ipv4 or ipv6. The functions rxe_prepare > and rxe_send are called after the functin rxe_init_packet. > So in these functions, av->network_type can be replaced with > skb->protocol. > The functions are in the xmit fast path. So with skb->protocol, > the performance will be better. > > Signed-off-by: Zhu Yanjun <yanjun.zhu@xxxxxxxxxx> > --- > drivers/infiniband/sw/rxe/rxe_net.c | 26 +++++++++++--------------- > 1 file changed, 11 insertions(+), 15 deletions(-) It doesn't compile, please rebase and resend: drivers/infiniband/sw/rxe/rxe_net.c: In function ‘rxe_prepare’: drivers/infiniband/sw/rxe/rxe_net.c:403:43: error: ‘av’ undeclared (first use in this function) if (ether_addr_equal(skb->dev->dev_addr, av->dmac)) ^~ Jason