Re: [PATCH v6 02/13] SIW main inclue file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 25, 2019 at 06:10:35PM +0100, Bernard Metzler wrote:
> Signed-off-by: Bernard Metzler <bmt@xxxxxxxxxxxxxx>
> ---
>  drivers/infiniband/sw/siw/siw.h | 747 ++++++++++++++++++++++++++++++++
>  1 file changed, 747 insertions(+)
>  create mode 100644 drivers/infiniband/sw/siw/siw.h
>
> diff --git a/drivers/infiniband/sw/siw/siw.h b/drivers/infiniband/sw/siw/siw.h
> new file mode 100644
> index 000000000000..619517941ebd
> --- /dev/null
> +++ b/drivers/infiniband/sw/siw/siw.h
> @@ -0,0 +1,747 @@
> +/* SPDX-License-Identifier: GPL-2.0 or BSD-3-Clause */
> +
> +/* Authors: Bernard Metzler <bmt@xxxxxxxxxxxxxx> */
> +/* Copyright (c) 2008-2019, IBM Corporation */
> +
> +#ifndef _SIW_H
> +#define _SIW_H
> +
> +#include <linux/idr.h>
> +#include <rdma/ib_verbs.h>
> +#include <linux/socket.h>
> +#include <linux/skbuff.h>
> +#include <linux/in.h>
> +#include <linux/fs.h>
> +#include <linux/netdevice.h>
> +#include <crypto/hash.h>
> +#include <linux/resource.h> /* MLOCK_LIMIT */
> +#include <linux/module.h>
> +#include <linux/version.h>
> +#include <linux/llist.h>
> +#include <linux/mm.h>
> +#include <linux/sched/signal.h>
> +
> +#include <rdma/siw_user.h>
> +#include "iwarp.h"
> +
> +#define DEBUG

Please without such defines.

> +
> +#define DEVICE_ID_SOFTIWARP 0x0815
> +#define SIW_VENDOR_ID 0x626d74 /* ascii 'bmt' for now */
> +#define SIW_VENDORT_PART_ID 0
> +#define SIW_MAX_QP (1024 * 100)
> +#define SIW_MAX_QP_WR (1024 * 32)
> +#define SIW_MAX_ORD_QP 128
> +#define SIW_MAX_IRD_QP 128
> +#define SIW_MAX_SGE_PBL 256 /* max num sge's for PBL */
> +#define SIW_MAX_SGE_RD 1 /* iwarp limitation. we could relax */
> +#define SIW_MAX_CQ (1024 * 100)
> +#define SIW_MAX_CQE (SIW_MAX_QP_WR * 100)
> +#define SIW_MAX_MR (SIW_MAX_QP * 10)
> +#define SIW_MAX_PD SIW_MAX_QP
> +#define SIW_MAX_MW 0 /* to be set if MW's are supported */
> +#define SIW_MAX_FMR SIW_MAX_MR
> +#define SIW_MAX_SRQ SIW_MAX_QP
> +#define SIW_MAX_SRQ_WR (SIW_MAX_QP_WR * 10)
> +#define SIW_MAX_CONTEXT SIW_MAX_PD
> +
> +/* Min number of bytes for using zero copy transmit */
> +#define SENDPAGE_THRESH PAGE_SIZE
> +
> +/* Maximum number of frames which can be send in one SQ processing */
> +#define SQ_USER_MAXBURST 100
> +
> +/* Maximum number of consecutive IRQ elements which get served
> + * if SQ has pending work. Prevents starving local SQ processing
> + * by serving peer Read Requests.
> + */
> +#define SIW_IRQ_MAXBURST_SQ_ACTIVE 4
> +
> +struct siw_dev_cap {
> +	int max_qp;
> +	int max_qp_wr;
> +	int max_ord; /* max. outbound read queue depth */
> +	int max_ird; /* max. inbound read queue depth */
> +	int max_sge;
> +	int max_sge_rd;
> +	int max_cq;
> +	int max_cqe;
> +	int max_mr;
> +	int max_pd;
> +	int max_mw;
> +	int max_fmr;
> +	int max_srq;
> +	int max_srq_wr;
> +	int max_srq_sge;
> +};
> +
> +struct siw_device {
> +	struct ib_device base_dev;
> +	struct net_device *netdev;
> +	struct siw_dev_cap attrs;
> +
> +	u32 vendor_part_id;
> +	int numa_node;
> +
> +	/* physical port state (only one port per device) */
> +	enum ib_port_state state;
> +
> +	spinlock_t lock;
> +
> +	/* object management */
> +	struct idr qp_idr;
> +	struct idr cq_idr;
> +	struct idr pd_idr;
> +	struct idr mem_idr;
> +
> +	struct list_head cep_list;
> +	struct list_head qp_list;
> +	struct list_head mr_list;
> +
> +	/* active objects statistics */
> +	atomic_t num_qp;
> +	atomic_t num_cq;
> +	atomic_t num_pd;
> +	atomic_t num_mr;
> +	atomic_t num_srq;
> +	atomic_t num_cep;
> +	atomic_t num_ctx;
> +
> +	struct dentry *debugfs;
> +	struct work_struct netdev_down;
> +};
> +
> +struct siw_objhdr {
> +	u32 id; /* for idr based object lookup */
> +	struct kref ref;
> +	struct siw_device *sdev;
> +};
> +
> +struct siw_uobj {
> +	struct list_head list;
> +	void *addr;
> +	u32 size;
> +	u32 key;
> +};
> +
> +struct siw_ucontext {
> +	struct ib_ucontext base_ucontext;
> +	struct siw_device *sdev;
> +
> +	/* List of user mappable queue objects */
> +	struct list_head uobj_list;
> +	spinlock_t uobj_lock;
> +	u32 uobj_key;
> +};
> +
> +struct siw_pd {
> +	struct ib_pd base_pd;
> +	struct siw_objhdr hdr;
> +};
> +
> +enum siw_access_flags {
> +	SIW_MEM_LREAD = (1 << 0),
> +	SIW_MEM_LWRITE = (1 << 1),
> +	SIW_MEM_RREAD = (1 << 2),
> +	SIW_MEM_RWRITE = (1 << 3),
> +
> +	SIW_MEM_FLAGS_LOCAL = (SIW_MEM_LREAD | SIW_MEM_LWRITE),
> +	SIW_MEM_FLAGS_REMOTE = (SIW_MEM_RWRITE | SIW_MEM_RREAD)
> +};
> +
> +struct siw_mr;
> +
> +/*
> + * siw presentation of user memory registered as source
> + * or target of RDMA operations.
> + */
> +
> +struct siw_page_chunk {
> +	struct page **p;
> +};
> +
> +struct siw_umem {
> +	struct siw_page_chunk *page_chunk;
> +	int num_pages;
> +	bool writable;
> +	u64 fp_addr; /* First page base address */
> +	struct mm_struct *owning_mm;
> +};
> +
> +struct siw_pble {
> +	u64 addr; /* Address of assigned user buffer */
> +	u64 size; /* Size of this entry */
> +	u64 pbl_off; /* Total offset from start of PBL */
> +};
> +
> +struct siw_pbl {
> +	unsigned int num_buf;
> +	unsigned int max_buf;
> +	struct siw_pble pbe[1];
> +};
> +
> +/*
> + * generic memory representation for registered siw memory.
> + * memory lookup always via higher 24 bit of stag (stag index).
> + * the stag is stored as part of the siw object header (id).
> + * object relates to memory window if embedded mr pointer is valid
> + */
> +struct siw_mem {
> +	struct siw_objhdr hdr;
> +
> +	struct siw_mr *mr; /* assoc. MR if MW, NULL if MR */
> +	u64 va; /* VA of memory */
> +	u64 len; /* amount of memory bytes */
> +
> +	u32 stag_valid : 1, /* VALID or INVALID */
> +		is_pbl : 1, /* PBL or user space mem */
> +		is_zbva : 1, /* zero based virt. addr. */
> +		mw_bind_enabled : 1, /* check only if MR */
> +		remote_inval_enabled : 1, /* VALID or INVALID */
> +		consumer_owns_key : 1, /* key/index split ? */
> +		rsvd : 26;
> +
> +	enum siw_access_flags perms; /* local/remote READ & WRITE */
> +};
> +
> +#define SIW_MEM_IS_MW(m) ((m)->mr != NULL)
> +
> +/*
> + * MR and MW definition.
> + * Used RDMA base structs ib_mr/ib_mw holding:
> + * lkey, rkey, MW reference count on MR
> + */
> +struct siw_mr {
> +	struct ib_mr base_mr;
> +	struct siw_mem mem;
> +	struct list_head devq;
> +	struct rcu_head rcu;
> +	union {
> +		struct siw_umem *umem;
> +		struct siw_pbl *pbl;
> +		void *mem_obj;
> +	};
> +	struct siw_pd *pd;
> +};
> +
> +struct siw_mw {
> +	struct ib_mw base_mw;
> +	struct siw_mem mem;
> +	struct rcu_head rcu;
> +};
> +
> +/*
> + * Error codes for local or remote
> + * access to registered memory
> + */
> +enum siw_access_state {
> +	E_ACCESS_OK = 0,
> +	E_STAG_INVALID,
> +	E_BASE_BOUNDS,
> +	E_ACCESS_PERM,
> +	E_PD_MISMATCH
> +};
> +
> +enum siw_wr_state {
> +	SIW_WR_IDLE = 0,
> +	SIW_WR_QUEUED = 1, /* processing has not started yet */
> +	SIW_WR_INPROGRESS = 2 /* initiated processing of the WR */
> +};
> +
> +/* The WQE currently being processed (RX or TX) */
> +struct siw_wqe {
> +	/* Copy of applications SQE or RQE */
> +	union {
> +		struct siw_sqe sqe;
> +		struct siw_rqe rqe;
> +	};
> +	struct siw_mem *mem[SIW_MAX_SGE]; /* per sge's resolved mem */
> +	enum siw_wr_state wr_status;
> +	enum siw_wc_status wc_status;
> +	u32 bytes; /* total bytes to process */
> +	u32 processed; /* bytes processed */
> +};
> +
> +struct siw_cq {
> +	struct ib_cq base_cq;
> +	struct siw_objhdr hdr;
> +	u64 *notify;
> +	spinlock_t lock;
> +	struct siw_cqe *queue;
> +	u32 cq_put;
> +	u32 cq_get;
> +	u32 num_cqe;
> +	int kernel_verbs;
> +};
> +
> +enum siw_qp_state {
> +	SIW_QP_STATE_IDLE = 0,
> +	SIW_QP_STATE_RTR = 1,
> +	SIW_QP_STATE_RTS = 2,
> +	SIW_QP_STATE_CLOSING = 3,
> +	SIW_QP_STATE_TERMINATE = 4,
> +	SIW_QP_STATE_ERROR = 5,
> +	SIW_QP_STATE_COUNT = 6
> +};
> +
> +enum siw_qp_flags {
> +	SIW_RDMA_BIND_ENABLED = (1 << 0),
> +	SIW_RDMA_WRITE_ENABLED = (1 << 1),
> +	SIW_RDMA_READ_ENABLED = (1 << 2),
> +	SIW_SIGNAL_ALL_WR = (1 << 3),
> +	SIW_MPA_CRC = (1 << 4),
> +	SIW_QP_IN_DESTROY = (1 << 5)
> +};
> +
> +enum siw_qp_attr_mask {
> +	SIW_QP_ATTR_STATE = (1 << 0),
> +	SIW_QP_ATTR_ACCESS_FLAGS = (1 << 1),
> +	SIW_QP_ATTR_LLP_HANDLE = (1 << 2),
> +	SIW_QP_ATTR_ORD = (1 << 3),
> +	SIW_QP_ATTR_IRD = (1 << 4),
> +	SIW_QP_ATTR_SQ_SIZE = (1 << 5),
> +	SIW_QP_ATTR_RQ_SIZE = (1 << 6),
> +	SIW_QP_ATTR_MPA = (1 << 7)
> +};
> +
> +struct siw_sk_upcalls {
> +	void (*sk_state_change)(struct sock *sk);
> +	void (*sk_data_ready)(struct sock *sk, int bytes);
> +	void (*sk_write_space)(struct sock *sk);
> +	void (*sk_error_report)(struct sock *sk);
> +};
> +
> +struct siw_srq {
> +	struct ib_srq base_srq;
> +	struct siw_pd *pd;
> +	atomic_t rq_index;
> +	spinlock_t lock;
> +	atomic_t space; /* current space for posting wqe's */
> +	u32 max_sge;
> +	u32 limit; /* low watermark for async event */
> +	struct siw_rqe *recvq;
> +	u32 rq_put;
> +	u32 rq_get;
> +	u32 num_rqe; /* max # of wqe's allowed */
> +	char armed; /* inform user if limit hit */
> +	char kernel_verbs; /* '1' if kernel client */
> +};
> +
> +struct siw_qp_attrs {
> +	enum siw_qp_state state;
> +	u32 sq_size;
> +	u32 rq_size;
> +	u32 orq_size;
> +	u32 irq_size;
> +	u32 sq_max_sges;
> +	u32 rq_max_sges;
> +	enum siw_qp_flags flags;
> +
> +	struct socket *sk;
> +};
> +
> +enum siw_tx_ctx {
> +	SIW_SEND_HDR = 0, /* start or continue sending HDR */
> +	SIW_SEND_DATA = 1, /* start or continue sending DDP payload */
> +	SIW_SEND_TRAILER = 2, /* start or continue sending TRAILER */
> +	SIW_SEND_SHORT_FPDU = 3 /* send whole FPDU hdr|data|trailer at once */
> +};
> +
> +enum siw_rx_state {
> +	SIW_GET_HDR = 0, /* await new hdr or within hdr */
> +	SIW_GET_DATA_START = 1, /* start of inbound DDP payload */
> +	SIW_GET_DATA_MORE = 2, /* continuation of (misaligned) DDP payload */
> +	SIW_GET_TRAILER = 3 /* await new trailer or within trailer */
> +};
> +
> +struct siw_iwarp_rx {
> +	struct sk_buff *skb;
> +	union iwarp_hdr hdr;
> +	struct mpa_trailer trailer;
> +	/*
> +	 * local destination memory of inbound iwarp operation.
> +	 * valid, according to wqe->wr_status
> +	 */
> +	struct siw_wqe wqe_active;
> +
> +	struct shash_desc *mpa_crc_hd;
> +	/*
> +	 * Next expected DDP MSN for each QN +
> +	 * expected steering tag +
> +	 * expected DDP tagget offset (all HBO)
> +	 */
> +	u32 ddp_msn[RDMAP_UNTAGGED_QN_COUNT];
> +	u32 ddp_stag;
> +	u64 ddp_to;
> +
> +	/*
> +	 * For each FPDU, main RX loop runs through 3 stages:
> +	 * Receiving protocol headers, placing DDP payload and receiving
> +	 * trailer information (CRC + eventual padding).
> +	 * Next two variables keep state on receive status of the
> +	 * current FPDU part (hdr, data, trailer).
> +	 */
> +	int fpdu_part_rcvd; /* bytes in pkt part copied */
> +	int fpdu_part_rem; /* bytes in pkt part not seen */
> +
> +	int skb_new; /* pending unread bytes in skb */
> +	int skb_offset; /* offset in skb */
> +	int skb_copied; /* processed bytes in skb */
> +
> +	int pbl_idx; /* Index into current PBL */
> +
> +	int sge_idx; /* current sge in rx */
> +	unsigned int sge_off; /* already rcvd in curr. sge */
> +
> +	enum siw_rx_state state;
> +
> +	u32 inval_stag; /* Stag to be invalidated */
> +
> +	u8 first_ddp_seg : 1, /* this is first DDP seg */
> +		more_ddp_segs : 1, /* more DDP segs expected */
> +		rx_suspend : 1, /* stop rcv DDP segs. */
> +		unused : 1, prev_rdmap_opcode : 4; /* opcode of prev msg */
> +	char pad; /* # of pad bytes expected */
> +};
> +
> +#define siw_rx_data(qp, ctx) \
> +	(iwarp_pktinfo[__rdmap_get_opcode(&ctx->hdr.ctrl)].proc_data(qp, ctx))
> +
> +/*
> + * Shorthands for short packets w/o payload
> + * to be transmitted more efficient.
> + */
> +struct siw_send_pkt {
> +	struct iwarp_send send;
> +	__be32 crc;
> +};
> +
> +struct siw_write_pkt {
> +	struct iwarp_rdma_write write;
> +	__be32 crc;
> +};
> +
> +struct siw_rreq_pkt {
> +	struct iwarp_rdma_rreq rreq;
> +	__be32 crc;
> +};
> +
> +struct siw_rresp_pkt {
> +	struct iwarp_rdma_rresp rresp;
> +	__be32 crc;
> +};
> +
> +struct siw_iwarp_tx {
> +	union {
> +		union iwarp_hdr hdr;
> +
> +		/* Generic part of FPDU header */
> +		struct iwarp_ctrl ctrl;
> +		struct iwarp_ctrl_untagged c_untagged;
> +		struct iwarp_ctrl_tagged c_tagged;
> +
> +		/* FPDU headers */
> +		struct iwarp_rdma_write rwrite;
> +		struct iwarp_rdma_rreq rreq;
> +		struct iwarp_rdma_rresp rresp;
> +		struct iwarp_terminate terminate;
> +		struct iwarp_send send;
> +		struct iwarp_send_inv send_inv;
> +
> +		/* complete short FPDUs */
> +		struct siw_send_pkt send_pkt;
> +		struct siw_write_pkt write_pkt;
> +		struct siw_rreq_pkt rreq_pkt;
> +		struct siw_rresp_pkt rresp_pkt;
> +	} pkt;
> +
> +	struct mpa_trailer trailer;
> +	/* DDP MSN for untagged messages */
> +	u32 ddp_msn[RDMAP_UNTAGGED_QN_COUNT];
> +
> +	enum siw_tx_ctx state;
> +	u16 ctrl_len; /* ddp+rdmap hdr */
> +	u16 ctrl_sent;
> +	int burst;
> +	int bytes_unsent; /* ddp payload bytes */
> +
> +	struct shash_desc *mpa_crc_hd;
> +
> +	u8 do_crc : 1, /* do crc for segment */
> +		use_sendpage : 1, /* send w/o copy */
> +		tx_suspend : 1, /* stop sending DDP segs. */
> +		pad : 2, /* # pad in current fpdu */
> +		orq_fence : 1, /* ORQ full or Send fenced */
> +		in_syscall : 1, /* TX out of user context */
> +		zcopy_tx : 1; /* Use TCP_SENDPAGE if possible */
> +	u8 gso_seg_limit; /* Maximum segments for GSO, 0 = unbound */
> +
> +	u16 fpdu_len; /* len of FPDU to tx */
> +	unsigned int tcp_seglen; /* remaining tcp seg space */
> +
> +	struct siw_wqe wqe_active;
> +
> +	int pbl_idx; /* Index into current PBL */
> +	int sge_idx; /* current sge in tx */
> +	u32 sge_off; /* already sent in curr. sge */
> +};
> +
> +struct siw_qp {
> +	struct ib_qp base_qp;
> +	struct siw_objhdr hdr;
> +	struct list_head devq;
> +	int tx_cpu;
> +	bool kernel_verbs;
> +	struct siw_qp_attrs attrs;
> +
> +	struct siw_cep *cep;
> +	struct rw_semaphore state_lock;
> +
> +	struct siw_pd *pd;
> +	struct siw_cq *scq;
> +	struct siw_cq *rcq;
> +	struct siw_srq *srq;
> +
> +	struct siw_iwarp_tx tx_ctx; /* Transmit context */
> +	spinlock_t sq_lock;
> +	struct siw_sqe *sendq; /* send queue element array */
> +	uint32_t sq_get; /* consumer index into sq array */
> +	uint32_t sq_put; /* kernel prod. index into sq array */
> +	struct llist_node tx_list;
> +
> +	struct siw_sqe *orq; /* outbound read queue element array */
> +	spinlock_t orq_lock;
> +	uint32_t orq_get; /* consumer index into orq array */
> +	uint32_t orq_put; /* shared producer index for ORQ */
> +
> +	struct siw_iwarp_rx rx_ctx; /* Receive context */
> +	spinlock_t rq_lock;
> +	struct siw_rqe *recvq; /* recv queue element array */
> +	uint32_t rq_get; /* consumer index into rq array */
> +	uint32_t rq_put; /* kernel prod. index into rq array */
> +
> +	struct siw_sqe *irq; /* inbound read queue element array */
> +	uint32_t irq_get; /* consumer index into irq array */
> +	uint32_t irq_put; /* producer index into irq array */
> +	int irq_burst;
> +
> +	struct { /* information to be carried in TERMINATE pkt, if valid */
> +		u8 valid;
> +		u8 in_tx;
> +		u8 layer : 4, etype : 4;
> +		u8 ecode;
> +	} term_info;
> +};
> +
> +/* helper macros */
> +#define rx_qp(rx) container_of(rx, struct siw_qp, rx_ctx)
> +#define tx_qp(tx) container_of(tx, struct siw_qp, tx_ctx)
> +#define tx_wqe(qp) (&(qp)->tx_ctx.wqe_active)
> +#define rx_wqe(qp) (&(qp)->rx_ctx.wqe_active)
> +#define rx_mem(qp) ((qp)->rx_ctx.wqe_active.mem[0])
> +#define tx_type(wqe) ((wqe)->sqe.opcode)
> +#define rx_type(wqe) ((wqe)->rqe.opcode)
> +#define tx_flags(wqe) ((wqe)->sqe.flags)
> +
> +#define QP_ID(qp) ((qp)->hdr.id)
> +#define OBJ_ID(obj) ((obj)->hdr.id)

First these defines are the same QP_ID(qp) == OBJ_ID(qp)
and second, please don't obfuscate "id", after we will convert all
objects to core allocation scheme, we will remove those IDs from all
drivers.

> +#define RX_QPID(rx) QP_ID(rx_qp(rx))
> +#define TX_QPID(tx) QP_ID(tx_qp(tx))
> +

Thanks

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux