On Wed, Mar 20, 2019 at 09:17:56PM +0200, Gal Pressman wrote: > On 20-Mar-19 21:13, Jason Gunthorpe wrote: > > On Wed, Mar 20, 2019 at 08:17:34PM +0200, Gal Pressman wrote: > > > >>> I haven't seen it yet, but I guess we have some core kernel code doing > >>> the pid now? > >> > >> Right, I'll start working on ibdev_{err,warn,...} helpers. > > > > Just copying the pattern in netdev is probably the thing to do, > > including the bit about deducing the device name under various > > conditions > > > > I also think we should have a ibdev_uapi_debug() which should be > > called for all the cases drivers have for uverbs calls checking > > arguments/etc > > > > Then we could have a global way to switch them on perhaps > > Global switch other than dynamic debug? Maybe a way to trigger them all at once in existing dynamic debug? I haven't looked Jason