Re: [PATCH v5 06/13] SIW application interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 20, 2019 at 05:59:29PM +0000, Bernard Metzler wrote:

> >> +	if (udata) {
> >> +		struct siw_uresp_create_qp uresp;
> >> +		struct siw_ucontext *ctx;
> >> +
> >> +		memset(&uresp, 0, sizeof(uresp));
> >> +		ctx = to_siw_ctx(base_pd->uobject->context);
> >
> >Here too, this is rdma_udata_to_drv_context()
> 
> With that ib_context and ib_udata dependence, shouldn't one of it
> be dropped in driver verbs methods like alloc_ucontext(), create_cq()?
> Both of it in one call seems to be redundant to me.

Yes.. Shamir was going to look at that as well

Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux