Re: [PATCH 1/1] IB: mlx4: move the variable into the function

[Yanjun Zhu <yanjun.zhu@xxxxxxxxxx>]

@@ -683,6 +682,7 @@ static int mlx4_ib_poll_one(struct mlx4_ib_cq *cq,
     u32 g_mlpath_rqpn;
     u16 wqe_ctr;
     unsigned tail = 0;
+    static struct mlx4_ib_qp *cur_qp = NULL;

Thanks a lot.

If a static is added, now can it get the same effect and make the source 
code compact?


 repoll:
     cqe = next_cqe_sw(cq);
@@ -720,8 +720,9 @@ static int mlx4_ib_poll_one(struct mlx4_ib_cq *cq,

On 2019/3/19 17:18, Leon Romanovsky wrote:
> The commit message and patch are incorrect. cur_qp is used here as
> "global variable" which is preserved during for loop.


Thanks. Probably a static should fix this. If you agree, I will send V2.


> Thanks