Re: [PATCH rdma-next v3 09/11] RDMA/efa: Add EFA verbs implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 14, 2019 at 03:23:49PM +0200, Gal Pressman wrote:
 
> I'm not certain that 32 bits are enough in this case.
> The eight most significant bits are reserved for internal coding, which leaves
> us with 24 bits for the key.

'internal coding' ? Why aren't those in the upper (32+PAGE_SIZE) bits?

> The key is increasing in strides of PAGE_SIZE (4k or possibly more).

No you always shift the key >> PAGE_SHIFT.

.. and with any scheme won't you run out of BAR pages well before you
hit an limit here.. Ie 24 bits of 4K pages is 68G of mappable space!

.. and if you are worried about such large lists then that linear
search is not going to cut it either.

Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux