> On Mar 11, 2019, at 10:13 AM, Jason Gunthorpe <jgg@xxxxxxxx> wrote: > > On Tue, Feb 19, 2019 at 11:08:50AM +0100, Bernard Metzler wrote: >> This patch set contributes version 5 of the SoftiWarp >> driver, as originally introduced to the list Oct 6th, 2017. >> SoftiWarp (siw) implements the iWarp RDMA protocol over >> kernel TCP sockets. The driver integrates with the >> linux-rdma framework. >> >> In response to the various helpful feedback, we fixed (besides >> other small fixes) the following issues: > > What I'd like to hear is that the uapi is designed properly in this > driver from a security perspective. > > 1) Kernel can only read-once any memory under control of user space to > avoid execution integrity security problems > > 2) Userspace never provides data that is unsafe, ie MAC addresses, IP > addresses, VLAN #s, etc. Anything that goes in a L2/L3 header of a > packet is a security problem > > 3) We don't have bugs like rxe has where the netdev side is assuming > lifetimes of IB objects that are not guaranteed - ie qps, ib_devs, > etc can be destroyed async to netdev stuff if userspace tries > hard enough. > > Finally, I want to hear from other people that this driver actually > works: > > - Chuck, does it run NFS work loads without crashing? > - Sagi, does it run NVMe workloads. > - Does it pass the various user space rdma-core ping test commands? > - Can it pass verbs fabtests from libfabric? Is someone planning to perform basic interop testing with h/w iWARP implementations? Not a high bar, just due diligence. -- Chuck Lever
