Hi Bernard, > -----Original Message----- > From: linux-rdma-owner@xxxxxxxxxxxxxxx <linux-rdma- > owner@xxxxxxxxxxxxxxx> On Behalf Of Bernard Metzler > Sent: Tuesday, February 19, 2019 4:09 AM > To: linux-rdma@xxxxxxxxxxxxxxx > Cc: Bernard Metzler <bmt@xxxxxxxxxxxxxx> > Subject: [PATCH v5 00/13] SIW: Request for Comments > > This patch set contributes version 5 of the SoftiWarp driver, as originally > introduced to the list Oct 6th, 2017. > SoftiWarp (siw) implements the iWarp RDMA protocol over kernel TCP > sockets. The driver integrates with the linux-rdma framework. > Great to see another software driver after rdma_rxe. rdma_rxe is improved incrementally by several people. rdma_rxe and siw have lot in common as below. 1. qp, mr, cq, srq resource allocation 2. state machine handling for qp, mr, srq 3. user interface for post_send, recv, cq poll, notification 4. user interface for resource creation qp, cq, mr, srq etc resources 5. data path handling for invalidate, send with invalidate etc 6. netlink life cycle commands for iwarp rdma devices What differs between them is - skb processing (roce) vs sockets (iwarp). This part of the transport layer is different between them. Hence please create transport callbacks to do transport specific work. So please reuse the rdma_rxe driver, refactor it to accommodate the need to iwarp.