Re: [PATCH 01/18] RDMA/core: Introduce new header file for signature operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2019-03-07 at 20:02 +-0200, Max Gurtovoy wrote:
+AD4 This commit ought to ease the exhausted ib+AF8-verbs.h file and make the
+AD4 code more readable.

If you have to repost this patch, please follow the following instructions
from Documentation/process/submitting-patches.rst:

Describe your changes in imperative mood, e.g. +ACI-make xyzzy do frotz+ACI
instead of +ACIAWw-This patch+AF0 makes xyzzy do frotz+ACI or +ACIAWw-I+AF0 changed xyzzy
to do frotz+ACI, as if you are giving orders to the codebase to change
its behaviour.

+AD4 +-/+ACoAKg
+AD4 +- +ACo Signature types
+AD4 +- +ACo IB+AF8-SIG+AF8-TYPE+AF8-NONE: Unprotected.
+AD4 +- +ACo IB+AF8-SIG+AF8-TYPE+AF8-T10+AF8-DIF: Type T10-DIF
+AD4 +- +ACo-/
+AD4 +-enum ib+AF8-signature+AF8-type +AHs
+AD4 +-	IB+AF8-SIG+AF8-TYPE+AF8-NONE,
+AD4 +-	IB+AF8-SIG+AF8-TYPE+AF8-T10+AF8-DIF,
+AD4 +-+AH0AOw

Since the block comment starts with +ACI-/+ACoAKgAi, please make sure that the comment
follows the kernel-doc syntax.

+AD4 +-/+ACoAKg
+AD4 +- +ACo Signature T10-DIF block-guard types
+AD4 +- +ACo IB+AF8-T10DIF+AF8-CRC: Corresponds to T10-PI mandated CRC checksum rules.
+AD4 +- +ACo IB+AF8-T10DIF+AF8-CSUM: Corresponds to IP checksum rules.
+AD4 +- +ACo-/
+AD4 +-enum ib+AF8-t10+AF8-dif+AF8-bg+AF8-type +AHs
+AD4 +-	IB+AF8-T10DIF+AF8-CRC,
+AD4 +-	IB+AF8-T10DIF+AF8-CSUM,
+AD4 +-+AH0AOw

Same comment here.

+AD4 +-/+ACoAKg
+AD4 +- +ACo Signature check masks (8 bytes in total) according to the T10-PI standard:
+AD4 +- +ACo  -------- -------- ------------
+AD4 +- +ACo +AHw GUARD  +AHw APPTAG +AHw   REFTAG   +AHw
+AD4 +- +ACo +AHw  2B    +AHw  2B    +AHw    4B      +AHw
+AD4 +- +ACo  -------- -------- ------------
+AD4 +- +ACo-/
+AD4 +-enum +AHs
+AD4 +-	IB+AF8-SIG+AF8-CHECK+AF8-GUARD +AD0 0xc0,
+AD4 +-	IB+AF8-SIG+AF8-CHECK+AF8-APPTAG +AD0 0x30,
+AD4 +-	IB+AF8-SIG+AF8-CHECK+AF8-REFTAG +AD0 0x0f,
+AD4 +-+AH0AOw

Same comment here.

Thanks,

Bart.



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux