On Tue, Mar 05, 2019 at 05:28:32PM +0200, Gal Pressman wrote: > >> Our link layer is Ethernet, but the wire protocol is not the same as RoCE so it > >> was decided to use unspecified link layer. > >> The wire protocol is tightly coupled to the wire protocol for EC2’s VPC software > >> defined network (EFA is not designed to be used independently of EC2’s VPC data > >> plane). > > > > It is possible this should just *_UNSPECIFIED/OTHER or something > > general so it can be shared. Neither USNIC nor EFA need these values > > for any purpose, AFAIK. > > > > They come out of sysfs and a few APIs they don't use anyhow. > > OK, I'll change the EFA stuff to unspecified (to be consistent with the link layer). > I'd rather leave the usnic definitions, but it's up to you, let me know what you > prefer. usnic is already abi, we shouldn't change it Jason
