On 04-Mar-19 23:28, Jason Gunthorpe wrote: > On Wed, Feb 27, 2019 at 10:29:11AM +0200, Gal Pressman wrote: >>>> + * Init cons_db to mark that all entries in the queue >>>> + * are initially available >>>> + */ >>>> + writel(edev->aenq.cc, edev->reg_bar + EFA_REGS_AENQ_CONS_DB_OFF); >>>> + >>> >>> >>> Do you need any barrier type operation here to ensure these values have >>> been read by HW? >> >> writel has an implicit barrier AFAIK. > > Yes > >>>> + err = efa_com_comp_status_to_errno(aq, comp_ctx->comp_status); >>>> +out: >>>> + efa_com_put_comp_ctx(aq, comp_ctx); >>>> + return err; >>>> +} >>>> + >> >>> Are all these function comments proper kdoc or whatever format? I >>> thought it should be /** to start? Or maybe it doesn't matter? >>> >> >> You're probably right. > > https://www.kernel.org/doc/html/v5.0/doc-guide/kernel-doc.html Thanks for this.
