---
Bernard Metzler, PhD
Tech. Leader High Performance I/O, Principal Research Staff
IBM Zurich Research Laboratory
Saeumerstrasse 4
CH-8803 Rueschlikon, Switzerland
+41 44 724 8605
-----"Leon Romanovsky" <leon@xxxxxxxxxx> wrote: -----
>To: "Bernard Metzler" <BMT@xxxxxxxxxxxxxx>
>From: "Leon Romanovsky" <leon@xxxxxxxxxx>
>Date: 02/28/2019 08:31PM
>Cc: "Gal Pressman" <galpress@xxxxxxxxxx>, linux-rdma@xxxxxxxxxxxxxxx
>Subject: Re: [PATCH v5 10/13] SIW receive path
>
>On Thu, Feb 28, 2019 at 02:47:39PM +0000, Bernard Metzler wrote:
>>
>>
>
><...>
>
>> >> +int siw_proc_send(struct siw_qp *qp, struct siw_iwarp_rx *rctx)
>> >> +{
>> >> + struct siw_wqe *wqe;
>> >> + struct siw_sge *sge;
>> >> + u32 data_bytes, /* all data bytes available */
>> >> + rcvd_bytes; /* sum of data bytes rcvd */
>> >
>> >Split declarations please, this applies to more occurrences in
>this
>> >file.
>> >
>> Please help me, I don't see what needs to be changed.
>
>He suggests to change the line above from "u32 data_bytes,
>rcvd_bytes;"
>to be "u32 data_bytes; u32 rcvd_bytes;"
>
>And please remove vertical space alignment.
>
yeah, this is what clang-format does for me ;)
Best,
Bernard.
