Re: [PATCH v5 13/13] SIW addition to kernel build environment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




---
Bernard Metzler, PhD
Tech. Leader High Performance I/O, Principal Research Staff
IBM Zurich Research Laboratory
Saeumerstrasse 4
CH-8803 Rueschlikon, Switzerland
+41 44 724 8605

-----"Gal Pressman" <galpress@xxxxxxxxxx> wrote: -----

>To: "Bernard Metzler" <bmt@xxxxxxxxxxxxxx>,
><linux-rdma@xxxxxxxxxxxxxxx>
>From: "Gal Pressman" <galpress@xxxxxxxxxx>
>Date: 02/28/2019 12:51PM
>Subject: Re: [PATCH v5 13/13] SIW addition to kernel build
>environment
>
>On 19-Feb-19 12:09, Bernard Metzler wrote:
>> Signed-off-by: Bernard Metzler <bmt@xxxxxxxxxxxxxx>
>> ---
>>  MAINTAINERS                        |  7 +++++++
>>  drivers/infiniband/Kconfig         |  1 +
>>  drivers/infiniband/sw/Makefile     |  1 +
>>  drivers/infiniband/sw/siw/Kconfig  | 17 +++++++++++++++++
>>  drivers/infiniband/sw/siw/Makefile | 15 +++++++++++++++
>>  5 files changed, 41 insertions(+)
>>  create mode 100644 drivers/infiniband/sw/siw/Kconfig
>>  create mode 100644 drivers/infiniband/sw/siw/Makefile
>> 
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 8c68de3cfd80..34f0f0c7af19 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -14055,6 +14055,13 @@ M:	Chris Boot <bootc@xxxxxxxxx>
>>  S:	Maintained
>>  F:	drivers/leds/leds-net48xx.c
>>  
>> +SOFT-ROCE DRIVER (siw)
>
>This is not a soft roce driver :).

Hahaha! good catch. thanks! I am happy I 
at least changed the maintainer after copypaste.

>
>> +M:	Bernard Metzler <bmt@xxxxxxxxxxxxxx>
>> +L:	linux-rdma@xxxxxxxxxxxxxxx
>> +S:	Supported
>> +F:	drivers/infiniband/sw/siw/
>> +F:	include/uapi/rdma/siw_user.h
>> +
>>  SOFT-ROCE DRIVER (rxe)
>>  M:	Moni Shoua <monis@xxxxxxxxxxxx>
>>  L:	linux-rdma@xxxxxxxxxxxxxxx
>> diff --git a/drivers/infiniband/Kconfig
>b/drivers/infiniband/Kconfig
>> index a1fb840de45d..6d160aac26df 100644
>> --- a/drivers/infiniband/Kconfig
>> +++ b/drivers/infiniband/Kconfig
>> @@ -107,6 +107,7 @@ source "drivers/infiniband/hw/hfi1/Kconfig"
>>  source "drivers/infiniband/hw/qedr/Kconfig"
>>  source "drivers/infiniband/sw/rdmavt/Kconfig"
>>  source "drivers/infiniband/sw/rxe/Kconfig"
>> +source "drivers/infiniband/sw/siw/Kconfig"
>>  endif
>>  
>>  source "drivers/infiniband/ulp/ipoib/Kconfig"
>> diff --git a/drivers/infiniband/sw/Makefile
>b/drivers/infiniband/sw/Makefile
>> index 8b095b27db87..d37610fcbbc7 100644
>> --- a/drivers/infiniband/sw/Makefile
>> +++ b/drivers/infiniband/sw/Makefile
>> @@ -1,2 +1,3 @@
>>  obj-$(CONFIG_INFINIBAND_RDMAVT)		+= rdmavt/
>>  obj-$(CONFIG_RDMA_RXE)			+= rxe/
>> +obj-$(CONFIG_RDMA_SIW)			+= siw/
>> diff --git a/drivers/infiniband/sw/siw/Kconfig
>b/drivers/infiniband/sw/siw/Kconfig
>> new file mode 100644
>> index 000000000000..f4f0210256bd
>> --- /dev/null
>> +++ b/drivers/infiniband/sw/siw/Kconfig
>> @@ -0,0 +1,17 @@
>> +config RDMA_SIW
>> +	tristate "Software RDMA over TCP/IP (iWARP) driver"
>> +	depends on INET && INFINIBAND && CRYPTO_CRC32
>> +	---help---
>
>According to checkpatch:
>WARNING: prefer 'help' over '---help---' for new help texts

OK, thanks!

>
>> +	This driver implements the iWARP RDMA transport over
>> +	the Linux TCP/IP network stack. It enables a system with a
>> +	standard Ethernet adapter to interoperate with a iWARP
>> +	adapter or with another system running the SIW driver.
>> +	(See also RXE which is a similar software driver for RoCE.)
>> +
>> +	The driver interfaces with the Linux RDMA stack and
>> +	implements both a kernel and user space RDMA verbs API.
>> +	The user space verbs API requires a support
>> +	library named libsiw which is loaded by the generic user
>> +	space verbs API, libibverbs. To implement RDMA over
>> +	TCP/IP, the driver further interfaces with the Linux
>> +	in-kernel TCP socket layer.
>> diff --git a/drivers/infiniband/sw/siw/Makefile
>b/drivers/infiniband/sw/siw/Makefile
>> new file mode 100644
>> index 000000000000..20f31c9e827b
>> --- /dev/null
>> +++ b/drivers/infiniband/sw/siw/Makefile
>> @@ -0,0 +1,15 @@
>> +obj-$(CONFIG_RDMA_SIW) += siw.o
>> +
>> +siw-y := \
>> +	siw_main.o \
>> +	siw_cm.o \
>> +	siw_verbs.o \
>> +	siw_obj.o \
>> +	siw_qp.o \
>> +	siw_qp_tx.o \
>> +	siw_qp_rx.o \
>> +	siw_cq.o \
>> +	siw_cm.o \
>> +	siw_debug.o \
>> +	siw_ae.o \
>> +	siw_mem.o
>> 
>
>Reviewed-by: Gal Pressman <galpress@xxxxxxxxxx>
>
>




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux