On 28-Feb-19 00:23, Saleem, Shiraz wrote: >> Subject: [PATCH rdma-next v2 10/11] RDMA/efa: Add the efa module >> >> Add the main EFA module file which takes care of device >> probe/initialization/registration/etc. >> >> Signed-off-by: Gal Pressman <galpress@xxxxxxxxxx> >> --- >> drivers/infiniband/hw/efa/efa_main.c | 577 >> +++++++++++++++++++++++++++++++++++ > > [...] >> +static int __init efa_init(void) >> +{ >> + int err; >> + >> + err = pci_register_driver(&efa_pci_driver); >> + if (err) { >> + pr_err("Couldn't register efa driver\n"); >> + goto err_register; > Nit: just return err here. >> + } >> + >> + return 0; >> + >> +err_register: >> + return err; >> +} >> + > > Reviewed-by: Shiraz Saleem <shiraz.saleem@xxxxxxxxx> Thanks Shiraz!