>Subject: [PATCH rdma-next v2 02/11] RDMA/efa: Add EFA device definitions
>
>EFA PCIe device implements a single Admin Queue (AQ) and Admin Completion
>Queue
>(ACQ) pair to initialize and communicate configuration with the device.
>Through this pair, we run set/get commands for querying and configuring the
>device, create/modify/destroy queues, and IB specific commands like Address
>Handler (AH), Memory Registration (MR) and Protection Domains (PD).
>
>In addition to admin (AQ/ACQ), we have data path queues that get classified as
>Queue Pairs (QP) and Completion Queues (CQ).
>
>Signed-off-by: Gal Pressman <galpress@xxxxxxxxxx>
>---
> drivers/infiniband/hw/efa/efa_admin_cmds_defs.h | 830
>++++++++++++++++++++++++
> drivers/infiniband/hw/efa/efa_admin_defs.h | 136 ++++
> drivers/infiniband/hw/efa/efa_common_defs.h | 18 +
> drivers/infiniband/hw/efa/efa_regs_defs.h | 113 ++++
> 4 files changed, 1097 insertions(+)
> create mode 100644 drivers/infiniband/hw/efa/efa_admin_cmds_defs.h
> create mode 100644 drivers/infiniband/hw/efa/efa_admin_defs.h
> create mode 100644 drivers/infiniband/hw/efa/efa_common_defs.h
> create mode 100644 drivers/infiniband/hw/efa/efa_regs_defs.h
>
>diff --git a/drivers/infiniband/hw/efa/efa_admin_cmds_defs.h
>b/drivers/infiniband/hw/efa/efa_admin_cmds_defs.h
>new file mode 100644
>index 000000000000..a7d82f75b3c7
>--- /dev/null
>+++ b/drivers/infiniband/hw/efa/efa_admin_cmds_defs.h
>@@ -0,0 +1,830 @@
>+/* SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause */
>+/*
>+ * Copyright 2018-2019 Amazon.com, Inc. or its affiliates. All rights reserved.
>+ */
>+
>+#ifndef _EFA_ADMIN_CMDS_H_
>+#define _EFA_ADMIN_CMDS_H_
>+
>+#define EFA_ADMIN_API_VERSION_MAJOR 0
>+#define EFA_ADMIN_API_VERSION_MINOR 1
>+
>+/* EFA admin queue opcodes */
>+enum efa_admin_aq_opcode {
>+ /* starting opcode of efa admin commands */
>+ EFA_ADMIN_START_CMD_RANGE = 1,
>+ /* Create QP */
>+ EFA_ADMIN_CREATE_QP =
>EFA_ADMIN_START_CMD_RANGE,
>+ /* Modify QP */
>+ EFA_ADMIN_MODIFY_QP = 2,
>+ /* Query QP */
>+ EFA_ADMIN_QUERY_QP = 3,
Some of the comments are redundant/overkill that you might want to consider removing.
Reviewed-by: Shiraz Saleem <shiraz.saleem@xxxxxxxxx>
