Re: [PATCH rdma-core 1/3] efa: Elastic Fabric Adapter (EFA) userspace RDMA provider

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 26, 2019 at 11:18:57AM +0200, Gal Pressman wrote:
> Introduce a provider that exposes EFA devices to user applications via
> the verbs interface.
>
> Signed-off-by: Gal Pressman <galpress@xxxxxxxxxx>
> ---
>  CMakeLists.txt                             |    1 +
>  MAINTAINERS                                |    5 +
>  README.md                                  |    1 +
>  debian/control                             |    9 +-
>  debian/copyright                           |    4 +
>  kernel-headers/CMakeLists.txt              |    2 +
>  kernel-headers/rdma/efa-abi.h              |  129 ++++
>  kernel-headers/rdma/rdma_user_ioctl_cmds.h |    1 +
>  libibverbs/verbs.h                         |    1 +
>  providers/efa/CMakeLists.txt               |    4 +
>  providers/efa/efa-abi.h                    |   56 ++
>  providers/efa/efa.c                        |  155 ++++
>  providers/efa/efa.h                        |  200 +++++
>  providers/efa/efa_io_defs.h                |  679 +++++++++++++++++
>  providers/efa/verbs.c                      | 1142 ++++++++++++++++++++++++++++
>  providers/efa/verbs.h                      |   72 ++
>  redhat/rdma-core.spec                      |    3 +
>  suse/rdma-core.spec                        |    2 +
>  18 files changed, 2463 insertions(+), 3 deletions(-)
>  create mode 100644 kernel-headers/rdma/efa-abi.h
>  create mode 100644 providers/efa/CMakeLists.txt
>  create mode 100644 providers/efa/efa-abi.h
>  create mode 100644 providers/efa/efa.c
>  create mode 100644 providers/efa/efa.h
>  create mode 100644 providers/efa/efa_io_defs.h
>  create mode 100644 providers/efa/verbs.c
>  create mode 100644 providers/efa/verbs.h

<...>

> +static inline unsigned long align(unsigned long val, unsigned long align)
> +{
> +	return (val + align - 1) & ~(align - 1);
> +}

Don't we already have helper for that?

> +
> +static inline uint32_t align_up_queue_size(uint32_t req)
> +{
> +	req--;
> +	req |= req >> 1;
> +	req |= req >> 2;
> +	req |= req >> 4;
> +	req |= req >> 8;
> +	req |= req >> 16;
> +	req++;
> +	return req;
> +}

What did you want to achieve with this?

Thanks

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux