Pyverbs will be using an all-capital class names conventions for acronyms, fix Gid to match that convention. This means breaking pyverbs' API, but since it's not used yet and currently offers very little functionality, it shouldn't make a difference. Signed-off-by: Noa Osherovich <noaos@xxxxxxxxxxxx> --- pyverbs/addr.pxd | 2 +- pyverbs/addr.pyx | 2 +- pyverbs/device.pyx | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pyverbs/addr.pxd b/pyverbs/addr.pxd index 39039379d517..313cd68fb0d2 100644 --- a/pyverbs/addr.pxd +++ b/pyverbs/addr.pxd @@ -5,5 +5,5 @@ from .base cimport PyverbsObject from pyverbs cimport libibverbs as v -cdef class Gid(PyverbsObject): +cdef class GID(PyverbsObject): cdef v.ibv_gid gid diff --git a/pyverbs/addr.pyx b/pyverbs/addr.pyx index 986521b90e82..0f171e83ea21 100644 --- a/pyverbs/addr.pyx +++ b/pyverbs/addr.pyx @@ -9,7 +9,7 @@ cdef extern from 'endian.h': unsigned long be64toh(unsigned long host_64bits) -cdef class Gid(PyverbsObject): +cdef class GID(PyverbsObject): """ GID class represents ibv_gid. It enables user to query for GIDs values. """ diff --git a/pyverbs/device.pyx b/pyverbs/device.pyx index a50bd2349445..3fad6af41ecc 100644 --- a/pyverbs/device.pyx +++ b/pyverbs/device.pyx @@ -10,7 +10,7 @@ from .pyverbs_error import PyverbsRDMAError from .pyverbs_error import PyverbsUserError from pyverbs.base import PyverbsRDMAErrno cimport pyverbs.libibverbs as v -from pyverbs.addr cimport Gid +from pyverbs.addr cimport GID cdef extern from 'errno.h': int errno @@ -134,7 +134,7 @@ cdef class Context(PyverbsObject): return dev_attr def query_gid(self, unsigned int port_num, int index): - gid = Gid() + gid = GID() rc = v.ibv_query_gid(self.context, port_num, index, &gid.gid) if rc != 0: raise PyverbsRDMAError('Failed to query gid {idx} of port {port}'. -- 2.17.2