Re: [PATCH v5 01/13] iWarp wire packet format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 19, 2019 at 11:08:51AM +0100, Bernard Metzler wrote:
> +struct iwarp_terminate {
> +	struct iwarp_ctrl ctrl;
> +	__be32	rsvd;
> +	__be32	ddp_qn;
> +	__be32	ddp_msn;
> +	__be32	ddp_mo;
> +#if defined(__LITTLE_ENDIAN_BITFIELD)
> +	__u16	layer:4,
> +		etype:4,
> +		ecode:8;
> +	__u16	flag_m:1,
> +		flag_d:1,
> +		flag_r:1,
> +		reserved:13;
> +#elif defined(__BIG_ENDIAN_BITFIELD)
> +	__u16	etype:4,
> +		layer:4,
> +		ecode:8;
> +	__u16	reserved:13,
> +		flag_r:1,
> +		flag_d:1,
> +		flag_m:1;
> +#else
> +#error "undefined byte order"
> +#endif

So, if you are going to do stuff like the above, why not do it
everywhere? Seems a bit weird that this field rated and the others
didn't

Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux