On 2/20/19 2:21 AM, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@xxxxxxxxxxxx>
>
> There is no need to keep same print functions for
> uint32_t and uint64_t, unify them into one function.
>
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> ---
> rdma/res.c | 22 +++++++---------------
> 1 file changed, 7 insertions(+), 15 deletions(-)
>
> diff --git a/rdma/res.c b/rdma/res.c
> index 6b0f5fe3..87865ec8 100644
> --- a/rdma/res.c
> +++ b/rdma/res.c
> @@ -808,28 +808,20 @@ static int res_cq_parse_cb(const struct nlmsghdr *nlh, void *data)
> return MNL_CB_OK;
> }
>
> -static void print_key(struct rd *rd, const char *name, uint32_t val)
> +static void print_key(struct rd *rd, const char *name, uint64_t val)
> {
> if (rd->json_output)
> jsonw_xint_field(rd->jw, name, val);
> else
> - pr_out("%s 0x%x ", name, val);
> + pr_out("%s 0x%" PRIx64 " ", name, val);
> }
what's the plan to move rdma tool to iproute2's json functions?
I realize rdma tool inherited this from devlink, but this command does
not need to continue managing this.
