On Wed, 2019-02-20 at 14:28 -0700, Jason Gunthorpe wrote: > On Wed, Feb 20, 2019 at 03:28:11PM -0500, Doug Ledford wrote: > > > Obviously, fixing the netlink would be the more robust solution. > > I think the way Parav has it works reasonably OK. The admin can toggle > the switch *before* creating any net namespaces and it is perfectly > atomic and non-disruptive. > > Trying to make it be a strong fence after net namespaces .. the best > we could probably do is to run over the client list and call a new > callback that should destroy anything outside the namespace. Or, alternatively, we just fail after namespaces have been created. I don't think it's out of reason to say that once namespaces are created, we can't change modes. > This would make particular sense if we also didn't do client > init/uninit during NS change but just let each client fix its own > stuff. > > Parav? Does any client other that uverbs need to do anything during NS > change? > > Jason -- Doug Ledford <dledford@xxxxxxxxxx> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
Attachment:
signature.asc
Description: This is a digitally signed message part