Re: [PATCH] Update MAINTAINERS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2019-02-19 at 19:57 +0100, Håkon Bugge wrote:
> > On 19 Feb 2019, at 14:10, Leon Romanovsky <leon@xxxxxxxxxx> wrote:
> > 
> > On Tue, Feb 19, 2019 at 01:58:02PM +0100, Håkon Bugge wrote:
> > > 
> > > > On 19 Feb 2019, at 13:39, Leon Romanovsky <leon@xxxxxxxxxx> wrote:
> > > > 
> > > > On Tue, Feb 19, 2019 at 10:09:16AM +0100, Håkon Bugge wrote:
> > > > > 
> > > > > > On 19 Feb 2019, at 08:41, Leon Romanovsky <leon@xxxxxxxxxx> wrote:
> > > > > > 
> > > > > > On Tue, Feb 19, 2019 at 03:59:25AM +0000, Jason Gunthorpe wrote:
> > > > > > > On Mon, Feb 18, 2019 at 11:00:33PM +0200, Leon Romanovsky wrote:
> > > > > > > > On Mon, Feb 18, 2019 at 08:38:20PM +0000, Jason Gunthorpe wrote:
> > > > > > > > > On Sun, Feb 17, 2019 at 07:24:52PM +0200, Leon Romanovsky wrote:
> > > > > > > > > > On Wed, Feb 13, 2019 at 10:00:31AM +0100, Håkon Bugge wrote:
> > > > > > > > > > > Add Mark and the undersigned as maintainers, removed Sean and Hal.
> > > > > > > > > > > 
> > > > > > > > > > > Signed-off-by: Håkon Bugge <haakon.bugge@xxxxxxxxxx>
> > > > > > > > > > 
> > > > > > > > > > Thanks applied with fix from Benjamin.
> > > > > > > > > > 
> > > > > > > > > > Håkon, I would like you to ask you do not use special symbols in git
> > > > > > > > > > patches, it doesn't survive git am/patchworks.
> > > > > > > > > 
> > > > > > > > > What flow did you use? I tested it and I didn't see a problem. IMHO
> > > > > > > > > this is a tooling bug.
> > > > > > > > > 
> > > > > > > > > I've been careful to keep things UTF-8 clean as it seems appropriate
> > > > > > > > > to keep special characters in people's names. (and somone once yelled
> > > > > > > > > at me for not using °C in a patch)
> > > > > > > > 
> > > > > > > > wget https://patchwork.kernel.org/patch/10809371/mbox/ | git am -s
> > > > > > > 
> > > > > > > Worked OK for me.. wget does locale conversions however, so your LANG=
> > > > > > > is probably not in a UTF-8 setting, or otherwise.
> > > > > > 
> > > > > > _  kernel git:(rdma-next) locale
> > > > > > LANG=en_US.UTF-8
> > > > > > LC_CTYPE="C"
> > > > > > LC_NUMERIC="C"
> > > > > > LC_TIME="C"
> > > > > > LC_COLLATE="C"
> > > > > > LC_MONETARY="C"
> > > > > > LC_MESSAGES="C"
> > > > > > LC_PAPER="C"
> > > > > > LC_NAME="C"
> > > > > > LC_ADDRESS="C"
> > > > > > LC_TELEPHONE="C"
> > > > > > LC_MEASUREMENT="C"
> > > > > > LC_IDENTIFICATION="C"
> > > > > > LC_ALL=C
> > > > > 
> > > > > Looks like most maintainers ar eable to cope with my "å":
> > > > 
> > > > Give me idea what should I need to change on my default linux machine
> > > > and I'll be able to cope with å too.
> > > 
> > > I have:
> > > 
> > > > locale
> > > LANG=en_US.UTF-8
> > > LC_CTYPE="en_US.UTF-8"
> > > LC_NUMERIC="en_US.UTF-8"
> > > LC_TIME="en_US.UTF-8"
> > > LC_COLLATE="en_US.UTF-8"
> > > LC_MONETARY="en_US.UTF-8"
> > > LC_MESSAGES="en_US.UTF-8"
> > > LC_PAPER="en_US.UTF-8"
> > > LC_NAME="en_US.UTF-8"
> > > LC_ADDRESS="en_US.UTF-8"
> > > LC_TELEPHONE="en_US.UTF-8"
> > > LC_MEASUREMENT="en_US.UTF-8"
> > > LC_IDENTIFICATION="en_US.UTF-8"
> > > LC_ALL=
> > > 
> > > 
> > > and I am using git version 2.20.1
> > 
> > The problem is with wget and not with git.
> > It is wget who rewrites å to something else.
> 
> Knut,
> 
> Any idea as to Leon's UTF issue?

I would have suspected the LC_ALL=C setting like Jason,
but my wget does not seem to change behaviour if I set LC_ALL=C,
whether set in .bashrc or just exported or set with env in the shell.

Leon, could it be that you have settings in a local ~/.wgetrc that causes 
issues? 

I tried setting localencoding and/or remoteencoding myself
but at least my wget seems to completely refuse to do anything wrong
with the proper encoded patchwork example above, whatever I try..

The documentation for wget says:

Wget use the function "nl_langinfo()" and then the "CHARSET" environment variable 
to get the locale. If it fails, ASCII is used.

but I wasn't able to make it break Håkon's "å" with CHARSET either..
Maybe your nl_langinfo somehow picks up the wrong info?

Which wget do you run?

I have wget-1.20.1-1.fc29.x86_64

Knut

> 
> Thxs, Håkon
> 




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux