On Tue, Feb 19, 2019 at 08:57:42AM -0600, Shiraz Saleem wrote: > > +struct sg_phys_iter { This should have umem in the name > + struct scatterlist *sg; > + unsigned long phyaddr; > + unsigned long len; > + unsigned long offset; > + unsigned long supported_pgsz; > + unsigned long remaining; > + unsigned int pg_bit; > + u8 mixed_pg_support; This should also be clear if it is a *dma* or *page* iterator, and which fields are public/private. Jason