Re: [PATCH rdma-next] RDMA/mlx5: Fix static analyzer error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> This kind of change makes the code confusing to human readers. Have you
> considered to add a BUG_ON(!qp) or WARN_ON(!qp) with a comment that
> refers to sparse instead?
>
> Thanks,
>
> Bart.
>
>
> This kind of change makes the code confusing to human readers. Have you
> considered to add a BUG_ON(!qp) or WARN_ON(!qp) with a comment that
> refers to sparse instead?
>
> Thanks,
>
I'm not sure that this kind of fix will satisfy the static checker. It
depends how it understand BUG_ON().

Moni



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux