On Mon, Feb 18, 2019 at 11:29:39AM +0200, Shamir Rabinovitch wrote:
> On Fri, Feb 15, 2019 at 03:46:07PM -0700, Jason Gunthorpe wrote:
> > On Thu, Feb 07, 2019 at 06:44:46PM +0200, Shamir Rabinovitch wrote:
> > > This patch set continue the cleanup started with Jason RFC patch. This
> > > patch set clean only the ib_xxx creation APIs because those APIs do have
> > > ib_udata.
> > >
> > > The final goal of this cleanup is to remove the dependency in the IB
> > > code in the ib_xxx->uobject pointer as step toward shared ib_xxx
> > > objects.
> > >
> > > Changelog:
> > >
> > > v3:
> > > - Jason: Modify helper rdma_udata_to_drv_context
> > > - Jason: Remove helper rdma_get_ucontext
> > > - Christoph Hellwig: Leave ib_udata as center of the user/kernel
> > > control flow
> > >
> > > v2:
> > > - Jason: Add the ib_ucontext to the attr bundle and make sure
> > > rdma_get_ucontext can't fail
> > > - Jason: Add helper macro to the the driver's context out of
> > > ib_udata
> > > - Leon: Un needed tests in mlx4_ib_db_unmap_user
> > >
> > >
> > > Shamir Rabinovitch (3):
> > > IB/uverbs: add ib_ucontext to uverbs_attr_bundle sent from ioctl and
> > > cmd flows
> > > IB/verbs: add helper function rdma_udata_to_drv_context
> > > IB/{hw,sw}: remove 'uobject->context' dependency in object creation
> > > APIs
> >
> > Applied to for-next, with a number of revisions
> > - Needed rebasing
> > - Fixes compilation failures in HNS. Enable COMPILE_TEST to get all
> > drivers turned on in .config
> > - Minor re-formatting
> > - Few missed conversion places in mlx5 raw qp and devx
> >
> > Please check over the patches I pushed to wip/jgg-for-next
>
> Jason,
>
> I only see the patch 1/3 on this branch.
> Have I missed anything?
commit 89944450547334aa6655e0cd4aec8df1897a205a
Author: Shamir Rabinovitch <shamir.rabinovitch@xxxxxxxxxx>
Date: Thu Feb 7 18:44:49 2019 +0200
IB/{hw,sw}: Remove 'uobject->context' dependency in object creation APIs
Now when we have the udata passed to all the ib_xxx object creation APIs
and the additional macro 'rdma_udata_to_drv_context' to get the
ib_ucontext from ib_udata stored in uverbs_attr_bundle, we can finally
start to remove the dependency of the drivers in the
ib_xxx->uobject->context.
Signed-off-by: Shamir Rabinovitch <shamir.rabinovitch@xxxxxxxxxx>
Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
commit 730623f4a56fa42d4559715ff2f4a5c32b3ae8bf
Author: Shamir Rabinovitch <shamir.rabinovitch@xxxxxxxxxx>
Date: Thu Feb 7 18:44:48 2019 +0200
IB/verbs: Add helper function rdma_udata_to_drv_context
Helper function to get driver's context out of ib_udata wrapped in
uverbs_attr_bundle for user objects or NULL for kernel objects.
Signed-off-by: Shamir Rabinovitch <shamir.rabinovitch@xxxxxxxxxx>
Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
commit 3d9dfd060391928bd615db62ecddea5e1255edfd
Author: Shamir Rabinovitch <shamir.rabinovitch@xxxxxxxxxx>
Date: Thu Feb 7 18:44:47 2019 +0200
IB/uverbs: Add ib_ucontext to uverbs_attr_bundle sent from ioctl and cmd flows
Add ib_ucontext to the uverbs_attr_bundle sent down the iocl and cmd flows
as soon as the flow has ib_uobject.
In addition, remove rdma_get_ucontext helper function that is only used by
ib_umem_get.
Signed-off-by: Shamir Rabinovitch <shamir.rabinovitch@xxxxxxxxxx>
Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
Jason
