Hi Parvi, I love your patch! Perhaps something to improve: [auto build test WARNING on rdma/for-next] [also build test WARNING on v5.0-rc4 next-20190208] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Parvi-Kaustubhi/IB-usnic-Fix-locking-when-unregistering/20190209-083958 base: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next config: x86_64-fedora-25 (attached as .config) compiler: gcc-7 (Debian 7.4.0-2) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All warnings (new ones prefixed by >>): drivers/infiniband/hw/usnic/usnic_ib_main.c: In function 'usnic_ib_netdevice_event': drivers/infiniband/hw/usnic/usnic_ib_main.c:223:10: error: implicit declaration of function 'ib_device_get_by_netdev'; did you mean 'ib_device_try_get'? [-Werror=implicit-function-declaration] ibdev = ib_device_get_by_netdev(netdev, RDMA_DRIVER_USNIC); ^~~~~~~~~~~~~~~~~~~~~~~ ib_device_try_get >> drivers/infiniband/hw/usnic/usnic_ib_main.c:223:8: warning: assignment makes pointer from integer without a cast [-Wint-conversion] ibdev = ib_device_get_by_netdev(netdev, RDMA_DRIVER_USNIC); ^ drivers/infiniband/hw/usnic/usnic_ib_main.c: In function 'usnic_ib_inetaddr_event': drivers/infiniband/hw/usnic/usnic_ib_main.c:286:8: warning: assignment makes pointer from integer without a cast [-Wint-conversion] ibdev = ib_device_get_by_netdev(netdev, RDMA_DRIVER_USNIC); ^ cc1: some warnings being treated as errors vim +223 drivers/infiniband/hw/usnic/usnic_ib_main.c 214 215 static int usnic_ib_netdevice_event(struct notifier_block *notifier, 216 unsigned long event, void *ptr) 217 { 218 struct usnic_ib_dev *us_ibdev; 219 struct ib_device *ibdev; 220 221 struct net_device *netdev = netdev_notifier_info_to_dev(ptr); 222 > 223 ibdev = ib_device_get_by_netdev(netdev, RDMA_DRIVER_USNIC); 224 if (!ibdev) 225 goto exit; 226 else 227 us_ibdev = container_of(ibdev, struct usnic_ib_dev, ib_dev); 228 usnic_ib_handle_usdev_event(us_ibdev, event); 229 exit: 230 return NOTIFY_DONE; 231 } 232 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
