Re: [PATCH for-rc 1/7] IB/{hfi1, qib, rdmavt}: Do not depend on IB Verbs name for driver logging

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 08, 2019 at 03:17:08PM +0000, Ruhl, Michael J wrote:
> I have an alternate patch that uses:
> 
> 1) a device name private to the rdmavt instance (for rdmavt logging)
> (adds the name as a char)

And how does rename work?

> 2) doesn't use the kobject from HFI

Delete it :(

> 3) doesn't use the char in QIB

> 4) uses hardwired text rather than a string in the logging
> function.: i.e : "hfi1_%d", dd->unit.

Would rather see this loggin as a core function like netdev does.

Why don't you fix the core code to allow early name assignment?

In fact my series here:

https://github.com/jgunthorpe/linux/commits/device_locking_cleanup

Does pretty much just that already, it needs two more lines and some
EXPORT_SYMBOLs, but otherwise does the job.

Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux