Re: [PATCH for-next v3 3/3] IB/{hw,sw}: remove 'uobject->context' dependency in object creation APIs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 07, 2019 at 06:44:49PM +0200, Shamir Rabinovitch wrote:
> Now when we have the udata passed to all the ib_xxx object creation APIs
> and the additional macro 'rdma_udata_to_drv_context' to get the ib_ucontext
> from ib_udata stored in uverbs_attr_bundle, we can finally start to remove
> the dependency of the drivers in the ib_xxx->uobject->context.
> 
> Signed-off-by: Shamir Rabinovitch <shamir.rabinovitch@xxxxxxxxxx>
> ---
>  drivers/infiniband/hw/bnxt_re/ib_verbs.c     | 24 ++++---
>  drivers/infiniband/hw/cxgb3/iwch_provider.c  |  4 +-
>  drivers/infiniband/hw/cxgb4/qp.c             | 10 +--
>  drivers/infiniband/hw/hns/hns_roce_qp.c      | 22 +++---
>  drivers/infiniband/hw/i40iw/i40iw_verbs.c    | 11 +--
>  drivers/infiniband/hw/mlx4/mr.c              | 11 ++-
>  drivers/infiniband/hw/mlx4/qp.c              | 74 +++++++++++---------
>  drivers/infiniband/hw/mlx4/srq.c             | 10 ++-
>  drivers/infiniband/hw/mlx5/qp.c              | 54 ++++++++------
>  drivers/infiniband/hw/mlx5/srq.c             |  9 +--
>  drivers/infiniband/hw/mthca/mthca_provider.c | 23 +++---
>  drivers/infiniband/hw/mthca/mthca_qp.c       | 14 ++--
>  drivers/infiniband/hw/mthca/mthca_srq.c      | 23 +++---
>  drivers/infiniband/hw/nes/nes_verbs.c        | 14 ++--
>  drivers/infiniband/hw/qedr/verbs.c           |  7 +-
>  drivers/infiniband/hw/usnic/usnic_ib_verbs.c |  6 +-
>  drivers/infiniband/sw/rdmavt/qp.c            | 10 ++-
>  drivers/infiniband/sw/rdmavt/srq.c           | 10 ++-
>  drivers/infiniband/sw/rxe/rxe_qp.c           |  8 ++-
>  drivers/infiniband/sw/rxe/rxe_verbs.c        |  6 +-
>  20 files changed, 209 insertions(+), 141 deletions(-)

Some of these could be tidied a bit more for udata vs ucontext, but it
isn't really worse than we have today.

I'd advise the driver maintainers to inspect this as I'm inclined to
apply the series in a few days.

Regards,
Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux