On Wed, Feb 06, 2019 at 03:45:35PM +0200, Gal Pressman wrote:
> Use is_power_of_2() instead of hard coding it in the driver.
> While at it, fix the meaningless error print.
>
> Signed-off-by: Gal Pressman <galpress@xxxxxxxxxx>
> Acked-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> ---
> drivers/infiniband/hw/mlx5/qp.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
applied to for-next thanks
Jason
> diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
> index 529e76f67cb6..c419c331a960 100644
> --- a/drivers/infiniband/hw/mlx5/qp.c
> +++ b/drivers/infiniband/hw/mlx5/qp.c
> @@ -435,9 +435,9 @@ static int set_user_buf_size(struct mlx5_ib_dev *dev,
> return -EINVAL;
> }
>
> - if (ucmd->sq_wqe_count && ((1 << ilog2(ucmd->sq_wqe_count)) != ucmd->sq_wqe_count)) {
> - mlx5_ib_warn(dev, "sq_wqe_count %d, sq_wqe_count %d\n",
> - ucmd->sq_wqe_count, ucmd->sq_wqe_count);
> + if (ucmd->sq_wqe_count && !is_power_of_2(ucmd->sq_wqe_count)) {
> + mlx5_ib_warn(dev, "sq_wqe_count %d is not a power of two\n",
> + ucmd->sq_wqe_count);
> return -EINVAL;
> }
>
