On 2/7/19 9:33 AM, Max Gurtovoy wrote:
This new WR will be used to perform PI (protection information) handover
using the new API. Using the new API, the user will post a single WR that
will internally perform all the needed actions to complete PI operation.
This new WR will use a memory region that was allocated as IB_MR_TYPE_PI
and was mapped using ib_map_mr_sg_pi to perform the registration. In the
old API, in order to perform a signature handover operation, each ULP
should perform the following:
1. Map and register the data buffers.
2. Map and register the protection buffers.
3. Post a special reg WR to configure the signature handover operation
layout.
4. Invalidate the signature memory key.
4. Invalidate protection buffers memory key.
5. Invalidate data buffers memory key.
In the new API, the mapping of both data and protection buffers is
performed using a single call to ib_map_mr_sg_pi function. Also the
registration of the buffers and the configuration of the signature
operation layout is done by a single new work request called
IB_WR_REG_PI_MR. This patch implements this operation for mlx5 devices
that are capable to offload data integrity generation/validation while
performing the actual buffer transfer. This patch will not remove the old
signature API that is used by the iSER initiator and target drivers. This
will be done in the future.
In the internal implementation, for each IB_WR_REG_PI_MR work request,
Again, lets stay consistent: IB_WR_REG_MR_INTEGRITY?
Other than that, seems reasonable.
Reviewed-by: Sagi Grimberg <sagi@xxxxxxxxxxx>
