Re: [PATCH rdma-next v4 9/9] RDMA/nldev: Provide parent IDs for PD, MR and QP objects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 07, 2019 at 05:14:54PM +0200, Gal Pressman wrote:
> On 02-Feb-19 13:42, Leon Romanovsky wrote:
> > +			ret = nla_put_u32(
> > +				msg, RDMA_NLDEV_ATTR_RES_CTXN,
> > +				rdma_res_to_id(&pd->uobject->context->res));
> 
> Hey Leon and Jason,
> Off topic: following the clang-format discussion in other thread, it looks like
> this kind of function calls are the result of clang. This causes checkpatch
> warnings (with strict flag):

I think this is a reasonable layout, other alternatives would be
longer than 80 cols, so pick the checkpatch warning you want to see :\

The only fix is to rework the code to not indent so deep.

> CHECK: Lines should not end with a '('.

If you use strict, take it with a big grain of salt. It often does
more harm than good, IHMO.

Jason




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux