On Thu, Feb 07, 2019 at 03:04:58AM +0000, Parvi Kaustubhi (pkaustub) wrote: > Incase of usnic, only the first vf for each enic pf (and not all > vfs) registers with ib. However, each vf that registers with ib has > it’s own netdevice. usnic_ib_ibdev_list_lock protects a list of the > those “first” vfs that have registered with ib. This series : > https://github.com/jgunthorpe/linux/commits/device_locking_cleanup , > will not allow us to get rid of this list (and hence > usnic_ib_ibdev_list_lock) completely. I wasn't thinking you could get rid of all of them, I did say 'many of them'. > We can modify the current patch such that driver doesn’t hold any > lock while doing ib_unregsiter_device() You should use the ib_device_set_netdev()/etc to eliminate the list from the netdev notifier path. There is also now an ib_unregister_device_queued() which might be useful here. Jason
