On Wed, 2019-02-06 at 13:04 -0800, Dan Williams wrote: > On Wed, Feb 6, 2019 at 12:14 PM Doug Ledford <dledford@xxxxxxxxxx> wrote: > > On Wed, 2019-02-06 at 11:45 -0800, Dan Williams wrote: > > > On Wed, Feb 6, 2019 at 10:52 AM Jason Gunthorpe <jgg@xxxxxxxx> wrote: > > > > On Wed, Feb 06, 2019 at 10:35:04AM -0800, Matthew Wilcox wrote: > > > > > > > > > > Admittedly, I'm coming in late to this conversation, but did I miss the > > > > > > portion where that alternative was ruled out? > > > > > > > > > > That's my preferred option too, but the preponderance of opinion leans > > > > > towards "We can't give people a way to make files un-truncatable". > > > > > > > > I haven't heard an explanation why blocking ftruncate is worse than > > > > giving people a way to break RDMA using process by calling ftruncate?? > > > > > > > > Isn't it exactly the same argument the other way? > > > > > > If the > > > RDMA application doesn't want it to happen, arrange for it by > > > permissions or other coordination to prevent truncation, > > > > I just argued the *exact* same thing, except from the other side: if you > > want a guaranteed ability to truncate, then arrange the perms so the > > RDMA or DAX capable things can't use the file. > > That doesn't make sense. All we have to work with is rwx bits. It's > possible to prevents writes / truncates. There's no permission bit for > mmap, O_DIRECT and RDMA mappings, hence leases. There's ownership. What you can't open, you can't mmap or O_DIRECT or whatever... Regardless though, this is mostly moot as Dave's email makes it clear the underlying issue that is the problem is not ftruncate, but other things. > > -- Doug Ledford <dledford@xxxxxxxxxx> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
Attachment:
signature.asc
Description: This is a digitally signed message part