Wed, Feb 06, 2019 at 12:53:19AM CET, f.fainelli@xxxxxxxxx wrote: >mlxsw implements SWITCHDEV_ATTR_ID_PORT_PARENT_ID and we want to get rid >of switchdev_ops eventually, ease that migration by implementing a >ndo_get_port_parent_id() function which returns what >switchdev_port_attr_get() would do. > >Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx> [...] >diff --git a/drivers/net/ethernet/mellanox/mlxsw/switchx2.c b/drivers/net/ethernet/mellanox/mlxsw/switchx2.c >index 2d4f213e154d..3814ba8af517 100644 >--- a/drivers/net/ethernet/mellanox/mlxsw/switchx2.c >+++ b/drivers/net/ethernet/mellanox/mlxsw/switchx2.c Please remove net/switchdev.h inclusion from this file, you don't need it any longer. Otherwise, looks fine. Acked-by: Jiri Pirko <jiri@xxxxxxxxxxxx> [...]