Wed, Feb 06, 2019 at 12:53:16AM CET, f.fainelli@xxxxxxxxx wrote: >BNXT only supports SWITCHDEV_ATTR_ID_PORT_PARENT_ID, which makes it a >great candidate to be converted to use the ndo_get_port_parent_id() NDO >instead of implementing switchdev_port_attr_get(). The conversion is >straight forward here since the PF and VF code use the same getter. > >Since bnxt makes uses of switchdev_port_same_parent_id() convert it to >use netdev_port_same_parent_id(). > >Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx> [...] >diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c >index c683b5e96b1d..170d2fbbb91b 100644 >--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c >+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c >@@ -12,6 +12,7 @@ > #include <linux/if_vlan.h> > #include <net/flow_dissector.h> > #include <net/pkt_cls.h> >+#include <net/switchdev.h> You don't need this. Looks like a leftover. Otherwise, looks fine. Acked-by: Jiri Pirko <jiri@xxxxxxxxxxxx> > #include <net/tc_act/tc_gact.h> > #include <net/tc_act/tc_skbedit.h> > #include <net/tc_act/tc_mirred.h> [...]
