> -----Original Message----- > From: Doug Ledford [mailto:dledford@xxxxxxxxxx] > Sent: Tuesday, February 05, 2019 12:04 PM > To: Dalessandro, Dennis <dennis.dalessandro@xxxxxxxxx>; jgg@xxxxxxxx > Cc: Dixit, Ashutosh <ashutosh.dixit@xxxxxxxxx>; linux-rdma@xxxxxxxxxxxxxxx; > Mitko Haralanov <mitko.haralanov@xxxxxxxxx>; Marciniszyn, Mike > <mike.marciniszyn@xxxxxxxxx>; Wan, Kaike <kaike.wan@xxxxxxxxx> > Subject: Re: [PATCH for-next 00/23] IB/hfi1: Add TID RDMA Write > > On Wed, 2019-01-23 at 21:48 -0800, Dennis Dalessandro wrote: > > Here is the final set of patches for TID RDMA. Again this is code > > which was previously submitted but re-organized so as to be easier to > review. > > > > Similar to how the READ series was organized the patches to build, > > receive, allocate resources etc are broken out. For details on TID > > RDMA as a whole again refer to the original cover letter. > > > > https://www.spinics.net/lists/linux-rdma/msg66611.html > > > > --- > > > > Kaike Wan (23): > > IB/hfi1: Build TID RDMA WRITE request > > IB/hfi1: Allow for extra entries in QP's s_ack_queue > > IB/hfi1: Add an s_acked_ack_queue pointer > > IB/hfi1: Add functions to receive TID RDMA WRITE request > > IB/hfi1: Add a function to build TID RDMA WRITE response > > IB/hfi1: Add TID resource timer > > IB/hfi1: Add a function to receive TID RDMA WRITE response > > IB/hfi1: Add a function to build TID RDMA WRITE DATA packet > > IB/hfi1: Add a function to receive TID RDMA WRITE DATA packet > > IB/hfi1: Add a function to build TID RDMA ACK packet > > IB/hfi1: Add a function to receive TID RDMA ACK packet > > IB/hfi1: Add TID RDMA retry timer > > IB/hfi1: Add a function to build TID RDMA RESYNC packet > > IB/hfi1: Add a function to receive TID RDMA RESYNC packet > > IB/hfi1: Resend the TID RDMA WRITE DATA packets > > IB/hfi1: Add the TID second leg send packet builder > > IB/hfi1: Add the TID second leg ACK packet builder > > IB/hfi1: Add the dual leg code > > IB/hfi1: Add TID RDMA WRITE functionality into RDMA verbs > > IB/hfi1: Add interlock between TID RDMA WRITE and other requests > > IB/hfi1: Enable TID RDMA WRITE protocol > > IB/hfi1: Add static trace for TID RDMA WRITE protocol > > IB/hfi1: Prioritize the sending of ACK packets > > > > > > drivers/infiniband/hw/hfi1/init.c | 1 > > drivers/infiniband/hw/hfi1/iowait.c | 34 > > drivers/infiniband/hw/hfi1/iowait.h | 99 + > > drivers/infiniband/hw/hfi1/opfn.c | 5 > > drivers/infiniband/hw/hfi1/pio.c | 18 > > drivers/infiniband/hw/hfi1/qp.c | 57 + > > drivers/infiniband/hw/hfi1/qp.h | 5 > > drivers/infiniband/hw/hfi1/rc.c | 542 ++++++ > > drivers/infiniband/hw/hfi1/rc.h | 1 > > drivers/infiniband/hw/hfi1/ruc.c | 32 > > drivers/infiniband/hw/hfi1/sdma.c | 24 > > drivers/infiniband/hw/hfi1/sdma_txreq.h | 1 > > drivers/infiniband/hw/hfi1/tid_rdma.c | 2504 > +++++++++++++++++++++++++++++ > > drivers/infiniband/hw/hfi1/tid_rdma.h | 88 + > > drivers/infiniband/hw/hfi1/trace.c | 66 + > > drivers/infiniband/hw/hfi1/trace_ibhdrs.h | 6 > > drivers/infiniband/hw/hfi1/trace_tid.h | 532 ++++++ > > drivers/infiniband/hw/hfi1/trace_tx.h | 6 > > drivers/infiniband/hw/hfi1/user_sdma.c | 9 > > drivers/infiniband/hw/hfi1/verbs.c | 20 > > drivers/infiniband/hw/hfi1/verbs.h | 35 > > drivers/infiniband/hw/hfi1/verbs_txreq.h | 1 > > drivers/infiniband/hw/hfi1/vnic_sdma.c | 6 > > drivers/infiniband/sw/rdmavt/qp.c | 1 > > include/rdma/ib_hdrs.h | 5 > > include/rdma/rdmavt_qp.h | 2 > > include/rdma/tid_rdma_defs.h | 56 + > > 27 files changed, 4025 insertions(+), 131 deletions(-) > > > > -- > > -Denny > > I'm not sure if this series was really that much easier to review, or if my brain > had simply glazed over after reviewing the Read TID support patch series. > Regardless, this patch series looks OK (I suspect it really was easier...most of > the locking and page counting stuff was already in the read series and just > reused here). Please post the respin of the read stuff soon. I'd like to > commit this before my eyes scab over and I can no longer see to push the > code to k.o ;-). Will do very soon. Thanks, Kaike > > -- > Doug Ledford <dledford@xxxxxxxxxx> > GPG KeyID: B826A3330E572FDD > Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
