On Tue, Feb 05, 2019 at 09:07:45AM -0700, Jason Gunthorpe wrote: > On Tue, Feb 05, 2019 at 04:19:14PM +0200, Gal Pressman wrote: > > > - list_for_each_entry(client, &client_list, list) > > > + xa_for_each_marked (&clients, index, client, CLIENT_REGISTERED) > > > > nit: extra space after xa_for_each_marked. > > meh. Some places in the kernel put the space, maby don't. In this case > clang-format wants to put the space for all 'for' macros (and who can > blame, it for should aways have a space). I hate to fight with > clang-format over such trivial things. Especially when there isn't a > specific requirement in coding style. Aha. Apparently I should add this: +++ b/.clang-format @@ -371,6 +371,12 @@ ForEachMacros: - 'v4l2_m2m_for_each_dst_buf_safe' - 'v4l2_m2m_for_each_src_buf' - 'v4l2_m2m_for_each_src_buf_safe' + - 'xa_for_each' + - 'xa_for_each_marked' + - 'xa_for_each_start' + - 'xas_for_each' + - 'xas_for_each_conflict' + - 'xas_for_each_marked' - 'zorro_for_each_dev' #IncludeBlocks: Preserve # Unknown to clang-format-5.0 As a non-clang user, I didn't ever bother with this file.
