> -----Original Message-----
> From: Jason Gunthorpe <jgg@xxxxxxxx>
> Sent: Monday, February 4, 2019 5:28 PM
> To: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>
> Cc: dledford@xxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx;
> BMT@xxxxxxxxxxxxxx; shiraz.saleem@xxxxxxxxx;
> tatyana.e.nikolova@xxxxxxxxx
> Subject: Re: [PATCH v2 rdma-next 3/3] RDMA/IWPM: Support no port
> mapping requirements
>
> On Tue, Jan 29, 2019 at 01:33:16PM -0800, Steve Wise wrote:
>
> > diff --git a/drivers/infiniband/core/iwpm_util.h
> b/drivers/infiniband/core/iwpm_util.h
> > index af1fc14a0d3d..7e2bcc72f66c 100644
> > +++ b/drivers/infiniband/core/iwpm_util.h
> > @@ -78,6 +78,7 @@ struct iwpm_mapping_info {
> > struct sockaddr_storage local_sockaddr;
> > struct sockaddr_storage mapped_sockaddr;
> > u8 nl_client;
> > + u32 map_flags;
> > };
> >
> > struct iwpm_remote_info {
> > @@ -266,4 +267,15 @@ int iwpm_parse_nlmsg(struct netlink_callback *cb,
> int policy_max,
> > * @msg: Message to print
> > */
> > void iwpm_print_sockaddr(struct sockaddr_storage *sockaddr, char
> *msg);
> > +
> > +/**
> > + * iwpm_send_hello - Send hello response to iwpmd
> > + *
> > + * @nl_client: The index of the netlink client
> > + * @abi_version: The kernel's abi_version
> > + *
> > + * Returns 0 on success or a negative error code
> > + */
> > +int iwpm_send_hello(u8 nl_client, int iwpm_pid, u16 abi_version);
>
> kdoc comments are placed above the function body in rdma.. Maybe send
> a patch move all of these?
>
> Jason
Sure, I can do that.
