-----"Leon Romanovsky" <leon@xxxxxxxxxx> wrote: ----- >To: bmt@xxxxxxxxxxxxxx >From: "Leon Romanovsky" <leon@xxxxxxxxxx> >Date: 01/30/2019 08:05PM >Cc: linux-rdma@xxxxxxxxxxxxxxx >Subject: Re: [PATCH v4 12/13] SIW debugging > >On Wed, Jan 30, 2019 at 06:21:35PM +0100, bmt@xxxxxxxxxxxxxx wrote: >> From: Bernard Metzler <bmt@xxxxxxxxxxxxxx> >> >> Signed-off-by: Bernard Metzler <bmt@xxxxxxxxxxxxxx> >> --- >> drivers/infiniband/sw/siw/siw_debug.c | 467 >++++++++++++++++++++++++++ >> drivers/infiniband/sw/siw/siw_debug.h | 87 +++++ >> 2 files changed, 554 insertions(+) >> create mode 100644 drivers/infiniband/sw/siw/siw_debug.c >> create mode 100644 drivers/infiniband/sw/siw/siw_debug.h >> > >1. ~550 LOCs without commit message is a little bit over. >2. The data exosed in this debugfs duplicated many info provided by >rdmatool. >Let's try without debugfs for now and add it later if it needed. OK, I see the point. So let me limit debug to dev debug for now, and check what is already provided by rdmatool. >3. Please don't redefine kernel functions (refcount_read, ...) > Absolutely, will fix that. Thanks, Bernard.
