On Wed, 2019-01-23 at 19:20 -0800, Dennis Dalessandro wrote:
> + /* Drop opfn.lock before calling ib_post_send() */
> + spin_unlock_irqrestore(&priv->opfn.lock, flags);
> +
> + ret = ib_post_send(&qp->ibqp, &wr.wr, NULL);
> + if (ret)
> + goto err;
> + return;
> +err:
> + spin_lock_irqsave(&priv->opfn.lock, flags);
> + /*
> + * In case of an unexpected error return from ib_post_send
> + * clear opfn.curr and reschedule to try again
> + */
This seems clunky. Why not if (!ret) return; and skip the whole goto?
--
Doug Ledford <dledford@xxxxxxxxxx>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
Attachment:
signature.asc
Description: This is a digitally signed message part
