Re: [PATCH for-rc 1/8] RDMA/hns: Bugfix for posting multiple srq work request

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 25, 2019 at 07:28:09AM -0500, Dennis Dalessandro wrote:
> On 1/25/2019 3:30 AM, Lijun Ou wrote:
> > When the user submits more than 32 work request to a srq queue
> > at a time, it needs to find the corresponding number of entries
> > in the bitmap in the idx queue. However, the original lookup
> > function named ffs only processes 32 bits of the array element,
> > When the number of srq wqe issued exceeds 32, the ffs will only
> > process the lower 32 bits of the elements, it will not be able
> > to get the correct wqe index for srq wqe.
> > 
> > Signed-off-by: Lijun Ou <oulijun@xxxxxxxxxx>
> 
> None of the patches in this series have a Fixes: line.

None of them have good enough commit messages for -rc.

If you want things in -rc you must do a much better job explaining why
it should be in -rc in the commit message.

I'm going to stop looking at your -rc patches at this rate.

Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux