On 1/23/19 11:08 AM, David Miller wrote: > From: "Gustavo A. R. Silva" <gustavo@xxxxxxxxxxxxxx> > Date: Wed, 23 Jan 2019 02:05:11 -0600 > >> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >> where we are expecting to fall through. >> >> This patch fixes the following warning: >> >> drivers/net/ethernet/mellanox/mlx4/eq.c: In function ʽmlx4_eq_intʼ: >> drivers/net/ethernet/mellanox/mlx4/mlx4.h:219:5: warning: this statement may fall through [-Wimplicit-fallthrough=] >> if (mlx4_debug_level) \ >> ^ >> drivers/net/ethernet/mellanox/mlx4/eq.c:558:4: note: in expansion of macro ʽmlx4_dbgʼ >> mlx4_dbg(dev, "%s: MLX4_EVENT_TYPE_SRQ_LIMIT. srq_no=0x%x, eq 0x%x\n", >> ^~~~~~~~ >> drivers/net/ethernet/mellanox/mlx4/eq.c:561:3: note: here >> case MLX4_EVENT_TYPE_SRQ_CATAS_ERROR: >> ^~~~ >> >> Warning level 3 was used: -Wimplicit-fallthrough=3 >> >> This patch is part of the ongoing efforts to enabling >> -Wimplicit-fallthrough. >> >> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx> > > Applied. > Thank you both, Tariq and David. -- Gustavo
