On Tue, 2019-01-22 at 19:48 +-0000, Jason Gunthorpe wrote: +AD4 On Tue, Jan 22, 2019 at 10:24:23AM -0800, Bart Van Assche wrote: +AD4 +AD4 This patch avoids that sparse complains about missing function declarations. +AD4 +AD4 +AD4 +AD4 Cc: Jason Gunthorpe +ADw-jgg+AEA-mellanox.com+AD4 +AD4 +AD4 Cc: Leon Romanovsky +ADw-leonro+AEA-mellanox.com+AD4 +AD4 +AD4 Cc: Doug Ledford +ADw-dledford+AEA-redhat.com+AD4 +AD4 +AD4 Fixes: f27a0d50a4bc (+ACI-RDMA/umem: Use umem-+AD4-owning+AF8-mm inside ODP+ACI) +ACM v4.20 +AD4 +AD4 Is this +ACM v4.20 a thing now? I haven't seen it before with fixes. It +AD4 is really easy to get the tag from a fixes with +AD4 'git describe --contains' Hi Jason, Mentioning the tag in a fixes commit is not required. I do that myself because it saves the reader the effort to run the git describe --contains command. Bart.