On 1/22/2019 11:46 AM, Leon Romanovsky wrote: > On Tue, Jan 22, 2019 at 09:09:35AM -0700, Jason Gunthorpe wrote: >> On Tue, Jan 22, 2019 at 10:00:00PM +0800, oulijun wrote: >>> Hi，jason & dledford >>> We are going to re-issue PATCHv6, and what else needs to be modified? >> Leon or Steve should review stuff related to the netlink interface. > I would like to repeat it, there is a need to update or RDMAtool or > IB/core to prefix those driver specific fields with driver name > to remove ambiguity and allow us to reuse common names like (e.g. cqn, > ci e.t.c.) later on. Should be easy to add the device name as a prefix in rdmatool. IE "cxgb4_cqn", "hns_ci". I don't think we need to change the kernel side, since the attributes are already tagged as "driver specific". Steve.
