Re: [PATCH for-rc 3/7] IB/{hfi1, qib}: Fix WC.byte_len calculation for UD_SEND_WITH_IMM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 17, 2019 at 12:41:32PM -0800, Dennis Dalessandro wrote:
> From: Brian Welty <brian.welty@xxxxxxxxx>
> 
> The work completion length for a receiving a UD send with immediate
> is short by 4 bytes.
> 
> The UD receive logic incorrectly subtracts 4 bytes for immediate
> value. These bytes are already included in header length and are
> used to calculate header/payload split, so the result is these
> 4 bytes are subtracted twice, once when the header length subtracted
> from the overall length and once again in the UD opcode specific
> path.  Remove the extra subtraction when handling the opcode.
> 
> Fixes: 7724105686e7 ("IB/hfi1: add driver files")
> Reviewed-by: Michael J. Ruhl <michael.j.ruhl@xxxxxxxxx>
> Signed-off-by: Brian Welty <brian.welty@xxxxxxxxx>
> Signed-off-by: Mike Marciniszyn <mike.marciniszyn@xxxxxxxxx>
> Signed-off-by: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx>
> ---
>  drivers/infiniband/hw/hfi1/ud.c    |    1 -
>  drivers/infiniband/hw/qib/qib_ud.c |    1 -
>  2 files changed, 0 insertions(+), 2 deletions(-)

Applied to for-rc thanks

Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux