On 1/11/2019 8:42 PM, Jason Gunthorpe wrote:
> No reason to open code this loop.
>
> Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
> ---
> drivers/infiniband/core/device.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
> index d42befb9fdb47a..5bb60371739a24 100644
> --- a/drivers/infiniband/core/device.c
> +++ b/drivers/infiniband/core/device.c
> @@ -217,18 +217,15 @@ EXPORT_SYMBOL(ib_device_get_by_name);
>
> int ib_device_rename(struct ib_device *ibdev, const char *name)
> {
> - struct ib_device *device;
> int ret = 0;
>
> if (!strcmp(name, dev_name(&ibdev->dev)))
> return ret;
>
> mutex_lock(&device_mutex);
> - list_for_each_entry(device, &device_list, core_list) {
> - if (!strcmp(name, dev_name(&device->dev))) {
> - ret = -EEXIST;
> - goto out;
> - }
> + if (__ib_device_get_by_name(name)) {
> + ret = -EEXIST;
> + goto out;
> }
>
> ret = device_rename(&ibdev->dev, name);
Looks fine.
Reviewed-by: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>
