Re: [PATCH rdma-rc] RDMA/uverbs: Mark ioctl responses with UVERBS_ATTR_F_VALID_OUTPUT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 14, 2019 at 02:03:12PM -0700, Jason Gunthorpe wrote:
> On Fri, Jan 11, 2019 at 08:21:44AM +0200, Leon Romanovsky wrote:
> > From: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
> > 
> > When the ioctl interface for the write commands was introduced it did
> > not mark the core response with UVERBS_ATTR_F_VALID_OUTPUT. This causes
> > rdma-core in userspace to not mark the buffers as written for valgrind.
> > 
> > Along the same lines it turns out we have always missed marking the driver
> > data. Fixing both of these makes valgrind work properly with rdma-core and
> > ioctl.
> > 
> > Fixes: 4785860e04bc ("RDMA/uverbs: Implement an ioctl that can call write and write_ex handlers")
> > Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
> > Reviewed-by: Artemy Kovalyov <artemyko@xxxxxxxxxxxx>
> > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> >  drivers/infiniband/core/rdma_core.h    |  2 +
> >  drivers/infiniband/core/uverbs_cmd.c   |  7 +++
> >  drivers/infiniband/core/uverbs_ioctl.c | 62 ++++++++++++++++++++------
> >  drivers/infiniband/core/uverbs_main.c  |  1 +
> >  4 files changed, 59 insertions(+), 13 deletions(-)
> 
> Applied to for-next

woops, I mean for-rc

Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux