Re: [PATCH rdma-next v3 02/10] RDMA: Introduce and use rdma_device_to_ibdev()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jan 12, 2019 at 04:13:27AM +0000, Parav Pandit wrote:

> > This should use container_of like the majority of the call sites it is replacing.
> > 
> > I made these changes and applied this as these wrappers are a helpful stand
> > alone improvement.
> > 
> Ok. thanks. If you took this patch, than same patch should have below change as well, which I cleaned up in a later patch.
> 
> index 8872453..d014717 100644
> +++ b/drivers/infiniband/core/device.c
> @@ -296,8 +296,6 @@ struct ib_device *ib_alloc_device(size_t size)
>         device->dev.class = &ib_class;
>         device_initialize(&device->dev);
> 
> -   dev_set_drvdata(&device->dev, device);
> -

Got it thanks

> > Can you check again that this got all the required driver call sites on the
> > latest tree?
> 
> Yes. I checked in for-next branch in
> https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git.  This
> patch is fine.

Great

Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux