Re: [PATCH for-rc 2/2] IB/mlx5: Fix how advise_mr() launches async work

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jan 12, 2019 at 05:06:02PM +0200, Leon Romanovsky wrote:
> On Fri, Jan 11, 2019 at 07:31:24PM -0700, Jason Gunthorpe wrote:
> > From: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
> >
> > Work must hold a kref on the ib_device otherwise the dev pointer can
> > become free before the work runs.
> 
> How can it occur exactly?
> 
> "dev" will be released after mlx5_ib will exist, mlx5_ib exist will
> drain advise_mr queue before it. Such drain will ensure that no works
> are running.

Okay, that is fine for the get_device, it can be removed.

Are we OK with the reg_state hunk?

Jason




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux