On Tue, Dec 18, 2018 at 02:16:00PM +0200, Leon Romanovsky wrote: > From: Parav Pandit <parav@xxxxxxxxxxxx> > > Add ib_ prefix to device_mutex, lists_rwsem and device_list to have > unique name and also to represent rdma/ib subsystem, such that > it can be shared using core_priv.h with multiple files of ib_core > module. I don't like all this churn just to put a few lines of code in another file.. In particular the locking is so complicated here I don't want to see any users of these locks outside this file. That only makes it harder to understand. Jason