Re: [PATCH 1/1] IB: rxe: replace spin lock with bitops in rxe cq

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2019/1/9 23:34, Jason Gunthorpe wrote:
On Wed, Jan 09, 2019 at 07:48:42AM -0500, Zhu Yanjun wrote:
It is a common way to use bitops to indicate the state. So replace spin
lock with bitops.
Umm, the spin locks also ensure other threads have exited their
critical sections, this is not an equivalent behavior if the spinlock
is not removed..

Did you check is it OK?

Sure. I also notice this before this patch. And I analyzed these critical sections.

It seems that this patch will not make difference on this. If I am missing something,

please feel free to let me know.

And I made tests with this patch for 2 days. All the tests including rds-ping, rds-stress, rping and

ibv_rc_pingpong can work well.

If any problem occurs with this patch, I will fix it.:-)

Zhu Yanjun


Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux